Skip to content

RHIDP-12524: Platform engineer define, name, and view aggregated KPIs for homepage#2183

Merged
rh-tokeefe merged 13 commits into
redhat-developer:mainfrom
rh-tokeefe:RHIDP-12524
May 29, 2026
Merged

RHIDP-12524: Platform engineer define, name, and view aggregated KPIs for homepage#2183
rh-tokeefe merged 13 commits into
redhat-developer:mainfrom
rh-tokeefe:RHIDP-12524

Conversation

@rh-tokeefe

@rh-tokeefe rh-tokeefe commented May 11, 2026

Copy link
Copy Markdown
Member

@rhdh-bot

rhdh-bot commented May 11, 2026

Copy link
Copy Markdown
Collaborator

PR Build Results

Build passed -- 34/34 titles | 75s
Preview: https://redhat-developer.github.io/red-hat-developers-documentation-rhdh/pr-2183/


Content Quality Assessment

CQA Report

  • CQA-00a: Orphaned modules
  • CQA-00b: Directory structure
  • CQA-01: Vale AsciiDoc DITA compliance
  • CQA-02: Verify assembly structure
  • CQA-03: Verify content type metadata
  • CQA-04: Verify module templates
  • CQA-05: Verify required modular elements
  • CQA-06: Verify assemblies follow official template (one user story)
  • CQA-07: Verify TOC depth (max 3 levels)
  • CQA-08: Verify short description content quality
  • CQA-09: Verify short description format
  • CQA-10: Verify titles are brief, complete, and descriptive
  • CQA-11: Verify procedure prerequisites
  • CQA-12: Verify grammar and style (Vale)
  • CQA-13: Verify content matches declared type
  • CQA-14: Verify no broken links
  • CQA-15: Check redirects
  • CQA-16: Verify official product names
  • CQA-17: Verify legal disclaimers for preview features

Summary

Checks: 19 total, 19 pass, 0 fail

19 checks: 19 pass, 0 fail

Run node build/scripts/cqa/index.js --all --fix locally to review and auto-fix issues.


Updated 2026-05-28 08:02:38 UTC

@PatAKnight PatAKnight left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of quick comments and then a comment here.

It seems like the task that is linked is for the aggregation feature: https://redhat.atlassian.net/browse/RHDHPLAN-411 which is more focused on the homepage cards and the ability to create new cards using the config. Whereas the feature: https://redhat.atlassian.net/browse/RHDHPLAN-915 was more of a focus on drilling down into those homepage cards to expose more information about the entities that went into making up that card. Overall the docs look good from the point of view the drill down feature. But probably does not capture the Configuring of KPIs with aggregated Scorecard data.

@rh-tokeefe

Copy link
Copy Markdown
Member Author

@PatAKnight I updated the existing procedure and added new topics based on your comments.

@PatAKnight PatAKnight left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Alright, went in and did another review. Also going to tag @imykhno since he was the one that contributed the aggregation feature. Added some more review comments to help tighten up the docs a bit.

@PatAKnight PatAKnight left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking pretty good, one final thing from me on one of the config values.

@rh-tokeefe rh-tokeefe added Technical review done ⛅ Any procedure has been succesfully tested Peer review needed 📖 and removed Technical review needed 🔩 Test all the procedures labels May 18, 2026
@sonarqubecloud

Copy link
Copy Markdown

@rh-tokeefe rh-tokeefe merged commit fbaada1 into redhat-developer:main May 29, 2026
6 checks passed
@rh-tokeefe

Copy link
Copy Markdown
Member Author

/cherrypick release-1.10

@openshift-cherrypick-robot

Copy link
Copy Markdown
Contributor

@rh-tokeefe: new pull request created: #2272

Details

In response to this:

/cherrypick release-1.10

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants